Refactor web auth #2706
Merged
Refactor web auth #2706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It isn't used by anything in auth, only in tests.
Codecov Report
@@ Coverage Diff @@
## master #2706 +/- ##
==========================================
+ Coverage 55.19% 55.21% +0.02%
==========================================
Files 561 565 +4
Lines 40917 40942 +25
==========================================
+ Hits 22584 22608 +24
- Misses 18333 18334 +1
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
johannaengland
approved these changes
Nov 3, 2023
lunkwill42
reviewed
Nov 3, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
johannaengland
approved these changes
Nov 6, 2023
lunkwill42
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves things around in order to make other things easier later, and easier to grasp in general. There should be no changes in functionality.
Pre-commit's black did not agree with everything that was there before so there are some additional changes.
This PR only does the easy bits, the real difficult part is splitting up/cleaning up
auth.authenticate. When that is done what's left in__init__.pycan probably move tolocal.pyor something like that.